Mark Terminate package test as flaky wrt #11087 #11088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Jul 22, 2025
geekosaur
requested changes
Jul 22, 2025
cabal-testsuite/PackageTests/NewBuild/CmdRun/Terminate/cabal.test.hs
Outdated
Show resolved
Hide resolved
ulysses4ever
approved these changes
Jul 22, 2025
|
Huh? The types _did_ catch it: look at CI.
|
|
ah, my bad!
On Tue, Jul 22, 2025 at 1:38 PM brandon s allbery kf8nh <
***@***.***> wrote:
… *geekosaur* left a comment (haskell/cabal#11088)
<#11088 (comment)>
Huh? The types _did_ catch it: look at CI.
brandon s allbery kf8nh
***@***.***
On Tue, Jul 22, 2025, 13:35 Artem Pelenitsyn ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> Thanks for the patch!
>
> Great catch, Brandon! So much for "strong typing" in Haskell. I wish the
> types didn't allow such mistakes.
>
> —
> Reply to this email directly, view it on GitHub
> <
#11088 (review)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAPRFIFLMHMZ3M3DC3KNK6L3JZY5FAVCNFSM6AAAAACCB2Y3CSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANBUGEYTSMRTGE>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#11088 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUEDWGUSR4BV6EFVV4O7UL3JZZIHAVCNFSM6AAAAACCB2Y3CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBUGAZTCMJUGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
geekosaur
approved these changes
Jul 23, 2025
|
as per https://github.com/haskell/cabal/blob/6d6fc4c772e1b8d3741d63878b8b2a35700fea08/CONTRIBUTING.md#github-pull-request-conventions, the author should set a merge label when they are ready for merging. |
mergify
bot
added
ready and waiting
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.